[release/9.0] Make RedisInsight work with WithLifetime(...).#6473
Merged
joperezr merged 5 commits intorelease/9.0from Oct 24, 2024
Merged
[release/9.0] Make RedisInsight work with WithLifetime(...).#6473joperezr merged 5 commits intorelease/9.0from
joperezr merged 5 commits intorelease/9.0from
Conversation
Member
|
Low Risk. Manually tested and added automation. Enabling a brand new feature in 9 to work correctly for RedisInsight. Approved. |
joperezr
approved these changes
Oct 24, 2024
joperezr
added a commit
to joperezr/aspire
that referenced
this pull request
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6425 to release/9.0
/cc @mitchdenny
Customer Impact
Currently when a developer makes Redis Insight persistent using the following code:
On subsequent runs RedisInsight will show additional instances of Redis (one for each launch of the apphost). This is because the import mechanism we use doesn't overwrite existing instances with the same name. This PR changes this logic so that we first pull the list of instances from RedisInsight and create the list of ones we want to delete, and then adds them back in via import).
The reason we delete is that the Redis instance may actually have changed credentials so we need to make sure the Redis instance has the correct credentials.
Testing
Manual testing and automated functional tests.
Risk
Low.
Regression?
Microsoft Reviewers: Open in CodeFlow